Skip to content

Remove unnecessary polyfills#1859

Merged
alcaeus merged 1 commit intomongodb:v2.xfrom
alcaeus:remove-unnecessary-polyfills
Mar 13, 2026
Merged

Remove unnecessary polyfills#1859
alcaeus merged 1 commit intomongodb:v2.xfrom
alcaeus:remove-unnecessary-polyfills

Conversation

@alcaeus
Copy link
Copy Markdown
Member

@alcaeus alcaeus commented Mar 13, 2026

Follow-up to #1858 (comment)

@alcaeus alcaeus requested a review from GromNaN March 13, 2026 12:52
@alcaeus alcaeus requested a review from a team as a code owner March 13, 2026 12:52
Copilot AI review requested due to automatic review settings March 13, 2026 12:52
@alcaeus alcaeus enabled auto-merge (squash) March 13, 2026 12:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unnecessary Symfony polyfill packages for PHP 8.2, 8.3, and 8.4 that were added in PR #1858 but are not actually used in the codebase. Only the PHP 8.5 polyfill (for array_first) is retained.

Changes:

  • Removed symfony/polyfill-php82, symfony/polyfill-php83, and symfony/polyfill-php84 from composer.json requirements

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.75%. Comparing base (bb2cd4c) to head (5d47c3c).
⚠️ Report is 8 commits behind head on v2.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x    #1859   +/-   ##
=========================================
  Coverage     87.75%   87.75%           
  Complexity     3308     3308           
=========================================
  Files           447      447           
  Lines          6607     6607           
=========================================
  Hits           5798     5798           
  Misses          809      809           
Flag Coverage Δ
6.0-replica_set 86.58% <ø> (ø)
6.0-server 82.60% <ø> (ø)
6.0-sharded_cluster 86.37% <ø> (ø)
8.0-replica_set 87.61% <ø> (ø)
8.0-server 83.35% <ø> (ø)
8.0-sharded_cluster 87.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alcaeus alcaeus merged commit 85fef97 into mongodb:v2.x Mar 13, 2026
39 checks passed
@alcaeus alcaeus deleted the remove-unnecessary-polyfills branch March 13, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants